Changeset 51451 for trunk/tests/phpunit/tests/ajax/Autosave.php

Timestamp:

07/17/2021 10:36:52 AM (23 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( strpos( ... ) > 0 ) with assertStringContainsString() to use native PHPUnit functionality.

Going forward, these methods introduced in PHPUnit 7.5 should be used for similar assertions:

• assertStringContainsString()
• assertStringNotContainsString()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449].

See #53363.

File:

• trunk/tests/phpunit/tests/ajax/Autosave.php (modified) (2 diffs)

trunk/tests/phpunit/tests/ajax/Autosave.php

@@ -80 +80 @@
         // Check that the edit happened.
         $post = get_post( self::$post_id );
-        $this->assertNotFalse( strpos( $post->post_content, $md5 ) );
+        $this->assertStringContainsString( $md5, $post->post_content );
     }
 
@@ -126 +126 @@
         // Check that the original post was NOT edited.
         $post = get_post( self::$post_id );
-        $this->assertFalse( strpos( $post->post_content, $md5 ) );
+        $this->assertStringNotContainsString( $md5, $post->post_content );
 
         // Check if the autosave post was created.
         $autosave = wp_get_post_autosave( self::$post_id, get_current_user_id() );
         $this->assertNotEmpty( $autosave );
-        $this->assertNotFalse( strpos( $autosave->post_content, $md5 ) );
+        $this->assertStringContainsString( $md5, $autosave->post_content );
     }