Changeset 51453

Timestamp:

07/18/2021 02:00:35 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in rest_sanitize_request_arg() tests.

This replaces instances of assertSame( true, ... ) with assertTrue() to use native PHPUnit functionality.

Follow-up to [38832].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-controller.php

@@ -112 +112 @@
 
                 // Check sanitize testing.
-                $this->assertSame(
-                        false,
+                $this->assertFalse(
                         rest_sanitize_request_arg( 'false', $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        false,
+                $this->assertFalse(
                         rest_sanitize_request_arg( '0', $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        false,
+                $this->assertFalse(
                         rest_sanitize_request_arg( 0, $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        false,
+                $this->assertFalse(
                         rest_sanitize_request_arg( 'FALSE', $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        true,
+                $this->assertTrue(
                         rest_sanitize_request_arg( 'true', $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        true,
+                $this->assertTrue(
                         rest_sanitize_request_arg( '1', $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        true,
+                $this->assertTrue(
                         rest_sanitize_request_arg( 1, $this->request, 'someboolean' )
                 );
-                $this->assertSame(
-                        true,
+                $this->assertTrue(
                         rest_sanitize_request_arg( 'TRUE', $this->request, 'someboolean' )
                 );