Changeset 51454 for trunk/tests/phpunit/tests/rest-api/rest-controller.php

Timestamp:

07/18/2021 02:10:24 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( ... > 0 ) with assertGreaterThan() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449], [51451], [51453].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-controller.php

@@ -514 +514 @@
         $first_call_count = $listener->get_call_count( $method );
 
-        $this->assertTrue( $first_call_count > 0 );
+        $this->assertGreaterThan( 0, $first_call_count );
 
         $request->set_param( '_fields', 'somestring' );
@@ -526 +526 @@
         $controller->prepare_item_for_response( $item, $request );
 
-        $this->assertTrue( $listener->get_call_count( $method ) > $first_call_count );
+        $this->assertGreaterThan( $first_call_count, $listener->get_call_count( $method ) );
     }