Changeset 51454 for trunk/tests/phpunit/tests/theme.php

Timestamp:

07/18/2021 02:10:24 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertTrue( ... > 0 ) with assertGreaterThan() to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449], [51451], [51453].

See #53363.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme.php

@@ -141 +141 @@
             $this->assertNotEmpty( $theme['Description'] );
             $this->assertNotEmpty( $theme['Author'] );
-            $this->assertTrue( version_compare( $theme['Version'], 0 ) > 0 );
+            $this->assertGreaterThan( 0, version_compare( $theme['Version'], 0 ) );
             $this->assertNotEmpty( $theme['Template'] );
             $this->assertNotEmpty( $theme['Stylesheet'] );