Changeset 51461 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

07/19/2021 01:29:45 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertFalse( stripos( ... ) ) with assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() to use native PHPUnit functionality.

Going forward, these methods introduced in PHPUnit 7.5 should be used for similar assertions:

• assertStringContainsString()
• assertStringContainsStringIgnoringCase()
• assertStringNotContainsString()
• assertStringNotContainsStringIgnoringCase()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449], [51451], [51453], [51454].

See #53363.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -822 +822 @@
             rest_url( '/wp/v2/comments' )
         );
-        $this->assertFalse( stripos( $headers['Link'], 'rel="prev"' ) );
+        $this->assertStringNotContainsString( 'rel="prev"', $headers['Link'] );
         $this->assertContains( '<' . $next_link . '>; rel="next"', $headers['Link'] );
 
@@ -868 +868 @@
         );
         $this->assertContains( '<' . $prev_link . '>; rel="prev"', $headers['Link'] );
-        $this->assertFalse( stripos( $headers['Link'], 'rel="next"' ) );
+        $this->assertStringNotContainsString( 'rel="next"', $headers['Link'] );
 
         // Out of bounds.
@@ -884 +884 @@
         );
         $this->assertContains( '<' . $prev_link . '>; rel="prev"', $headers['Link'] );
-        $this->assertFalse( stripos( $headers['Link'], 'rel="next"' ) );
+        $this->assertStringNotContainsString( 'rel="next"', $headers['Link'] );
     }