Make WordPress Core


Ignore:
Timestamp:
07/19/2021 01:29:45 PM (3 years ago)
Author:
SergeyBiryukov
Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertFalse( stripos( ... ) ) with assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() to use native PHPUnit functionality.

Going forward, these methods introduced in PHPUnit 7.5 should be used for similar assertions:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase()
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449], [51451], [51453], [51454].

See #53363.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php

    r51208 r51461  
    177177            $search_field_values = $pattern['title'] . ' ' . $pattern['description'];
    178178
    179             $this->assertNotFalse( stripos( $search_field_values, $search_term ) );
     179            $this->assertStringContainsStringIgnoringCase( $search_term, $search_field_values );
    180180        }
    181181    }
Note: See TracChangeset for help on using the changeset viewer.