Make WordPress Core


Ignore:
Timestamp:
07/19/2021 01:29:45 PM (3 years ago)
Author:
SergeyBiryukov
Message:

Tests: Use more appropriate assertions in various tests.

This replaces instances of assertFalse( stripos( ... ) ) with assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() to use native PHPUnit functionality.

Going forward, these methods introduced in PHPUnit 7.5 should be used for similar assertions:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase()
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase()

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods are now added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51335], [51337], [51367], [51397], [51403], [51404], [51436], [51438], [51448], [51449], [51451], [51453], [51454].

See #53363.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

    r51404 r51461  
    591591            rest_url( 'wp/v2/tags' )
    592592        );
    593         $this->assertFalse( stripos( $headers['Link'], 'rel="prev"' ) );
     593        $this->assertStringNotContainsString( 'rel="prev"', $headers['Link'] );
    594594        $this->assertContains( '<' . $next_link . '>; rel="next"', $headers['Link'] );
    595595
     
    633633        );
    634634        $this->assertContains( '<' . $prev_link . '>; rel="prev"', $headers['Link'] );
    635         $this->assertFalse( stripos( $headers['Link'], 'rel="next"' ) );
     635        $this->assertStringNotContainsString( 'rel="next"', $headers['Link'] );
    636636
    637637        // Out of bounds.
     
    649649        );
    650650        $this->assertContains( '<' . $prev_link . '>; rel="prev"', $headers['Link'] );
    651         $this->assertFalse( stripos( $headers['Link'], 'rel="next"' ) );
     651        $this->assertStringNotContainsString( 'rel="next"', $headers['Link'] );
    652652    }
    653653
Note: See TracChangeset for help on using the changeset viewer.