WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/19/2021 02:00:11 PM (6 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace assertContains() with assertStringContainsString() when used with strings.

Using the assertContains() and assertNotContains() methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51331], [51451], [51461].

Props jrf, dd32, SergeyBiryukov.
See #53363, #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/admin/includesTemplate.php

    r51419 r51462  
    1818        );
    1919
    20         $this->assertContains( "checked='checked'", $output );
     20        $this->assertStringContainsString( "checked='checked'", $output );
    2121    }
    2222
     
    3434        );
    3535
    36         $this->assertContains( 'class="popular-category"', $output );
     36        $this->assertStringContainsString( 'class="popular-category"', $output );
    3737    }
    3838
     
    186186        $expected = sprintf( 'notice %s settings-error is-dismissible', $expected );
    187187
    188         $this->assertContains( $expected, $output );
    189         $this->assertNotContains( 'notice-notice-', $output );
     188        $this->assertStringContainsString( $expected, $output );
     189        $this->assertStringNotContainsString( 'notice-notice-', $output );
    190190    }
    191191
Note: See TracChangeset for help on using the changeset viewer.