WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/19/2021 02:00:11 PM (6 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace assertContains() with assertStringContainsString() when used with strings.

Using the assertContains() and assertNotContains() methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51331], [51451], [51461].

Props jrf, dd32, SergeyBiryukov.
See #53363, #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/ajax/Compression.php

    r49025 r51462  
    5050
    5151        // Ensure we found the right match.
    52         $this->assertContains( 'wpCompressionTest', $this->_last_response );
     52        $this->assertStringContainsString( 'wpCompressionTest', $this->_last_response );
    5353    }
    5454
     
    7575
    7676        // Ensure we found the right match.
    77         $this->assertContains( 'wpCompressionTest', gzinflate( $this->_last_response ) );
     77        $this->assertStringContainsString( 'wpCompressionTest', gzinflate( $this->_last_response ) );
    7878    }
    7979
     
    100100
    101101        // Ensure we found the right match.
    102         $this->assertContains( 'wpCompressionTest', $this->_gzdecode( $this->_last_response ) );
     102        $this->assertStringContainsString( 'wpCompressionTest', $this->_gzdecode( $this->_last_response ) );
    103103    }
    104104
Note: See TracChangeset for help on using the changeset viewer.