Make WordPress Core


Ignore:
Timestamp:
07/19/2021 02:00:11 PM (6 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace assertContains() with assertStringContainsString() when used with strings.

Using the assertContains() and assertNotContains() methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51331], [51451], [51461].

Props jrf, dd32, SergeyBiryukov.
See #53363, #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/post/template.php

    r50396 r51462  
    238238
    239239        // Should contain page ID by default.
    240         $this->assertContains( 'value="' . $p . '"', $found );
     240        $this->assertStringContainsString( 'value="' . $p . '"', $found );
    241241    }
    242242
     
    258258        );
    259259
    260         $this->assertContains( 'value="' . $p . '"', $found );
     260        $this->assertStringContainsString( 'value="' . $p . '"', $found );
    261261    }
    262262
     
    279279        );
    280280
    281         $this->assertContains( 'value="foo"', $found );
     281        $this->assertStringContainsString( 'value="foo"', $found );
    282282    }
    283283
     
    300300        );
    301301
    302         $this->assertContains( 'value="' . $p . '"', $found );
     302        $this->assertStringContainsString( 'value="' . $p . '"', $found );
    303303    }
    304304
Note: See TracChangeset for help on using the changeset viewer.