Make WordPress Core


Ignore:
Timestamp:
07/19/2021 02:00:11 PM (6 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace assertContains() with assertStringContainsString() when used with strings.

Using the assertContains() and assertNotContains() methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51331], [51451], [51461].

Props jrf, dd32, SergeyBiryukov.
See #53363, #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/query.php

    r48939 r51462  
    155155        );
    156156
    157         $this->assertContains( "ORDER BY $wpdb->posts.post_title DESC, $wpdb->posts.post_date DESC", $q->request );
     157        $this->assertStringContainsString( "ORDER BY $wpdb->posts.post_title DESC, $wpdb->posts.post_date DESC", $q->request );
    158158    }
    159159
     
    572572        );
    573573
    574         $this->assertContains( 'LIMIT 0, 5', $q->request );
     574        $this->assertStringContainsString( 'LIMIT 0, 5', $q->request );
    575575    }
    576576
     
    586586        );
    587587
    588         $this->assertContains( 'LIMIT 5, 5', $q->request );
     588        $this->assertStringContainsString( 'LIMIT 5, 5', $q->request );
    589589    }
    590590
     
    601601        );
    602602
    603         $this->assertContains( 'LIMIT 5, 5', $q->request );
     603        $this->assertStringContainsString( 'LIMIT 5, 5', $q->request );
    604604    }
    605605
Note: See TracChangeset for help on using the changeset viewer.