Make WordPress Core


Ignore:
Timestamp:
07/19/2021 02:00:11 PM (6 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace assertContains() with assertStringContainsString() when used with strings.

Using the assertContains() and assertNotContains() methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51331], [51451], [51461].

Props jrf, dd32, SergeyBiryukov.
See #53363, #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/query/postStatus.php

    r51419 r51462  
    118118        );
    119119
    120         $this->assertContains( "post_status <> 'foo'", $q->request );
     120        $this->assertStringContainsString( "post_status <> 'foo'", $q->request );
    121121    }
    122122
     
    130130        );
    131131
    132         $this->assertNotContains( "post_status <> 'foo'", $q->request );
     132        $this->assertStringNotContainsString( "post_status <> 'foo'", $q->request );
    133133    }
    134134
     
    242242
    243243        foreach ( get_post_stati( array( 'public' => true ) ) as $status ) {
    244             $this->assertContains( "post_status = '$status'", $q->request );
     244            $this->assertStringContainsString( "post_status = '$status'", $q->request );
    245245        }
    246246    }
     
    255255        );
    256256
    257         $this->assertNotContains( "post_status = 'foo", $q->request );
     257        $this->assertStringNotContainsString( "post_status = 'foo", $q->request );
    258258    }
    259259
     
    274274        );
    275275
    276         $this->assertContains( "post_status = 'foo", $q->request );
     276        $this->assertStringContainsString( "post_status = 'foo", $q->request );
    277277    }
    278278
Note: See TracChangeset for help on using the changeset viewer.