WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/19/2021 02:00:11 PM (6 months ago)
Author:
SergeyBiryukov
Message:

Tests: Replace assertContains() with assertStringContainsString() when used with strings.

Using the assertContains() and assertNotContains() methods with string haystacks was deprecated in PHPUnit 8 and removed in PHPUnit 9.

While WordPress test suite currently only supports PHPUnit up to 7.5.x, this allows us to switch to newer assertions ahead of adding full support for PHPUnit 8+.

These methods introduced in PHPUnit 7.5 should be used as an alternative:

  • assertStringContainsString()
  • assertStringContainsStringIgnoringCase
  • assertStringNotContainsString()
  • assertStringNotContainsStringIgnoringCase

As WordPress currently uses PHPUnit 5.7.x to run tests on PHP 5.6, polyfills for these methods were added to the WP_UnitTestCase class for PHPUnit < 7.5.

Follow-up to [51331], [51451], [51461].

Props jrf, dd32, SergeyBiryukov.
See #53363, #46149.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/widgets/media-gallery-widget.php

    r51415 r51462  
    8282        $output = ob_get_clean();
    8383
    84         $this->assertContains( 'gallery-columns-3', $output );
    85         $this->assertContains( 'gallery-size-thumbnail', $output );
    86         $this->assertContains( 'canola', $output );
    87         $this->assertContains( 'waffles', $output );
     84        $this->assertStringContainsString( 'gallery-columns-3', $output );
     85        $this->assertStringContainsString( 'gallery-size-thumbnail', $output );
     86        $this->assertStringContainsString( 'canola', $output );
     87        $this->assertStringContainsString( 'waffles', $output );
    8888    }
    8989
     
    104104
    105105        $after = implode( '', wp_scripts()->registered['media-gallery-widget']->extra['after'] );
    106         $this->assertContains( 'wp.mediaWidgets.modelConstructors[ "media_gallery" ].prototype', $after );
     106        $this->assertStringContainsString( 'wp.mediaWidgets.modelConstructors[ "media_gallery" ].prototype', $after );
    107107    }
    108108
     
    200200        $output = ob_get_clean();
    201201
    202         $this->assertContains( '<script type="text/html" id="tmpl-wp-media-widget-gallery-preview">', $output );
     202        $this->assertStringContainsString( '<script type="text/html" id="tmpl-wp-media-widget-gallery-preview">', $output );
    203203    }
    204204}
Note: See TracChangeset for help on using the changeset viewer.