Changeset 51471

Timestamp:

07/22/2021 08:36:11 AM (5 years ago)

Author:

gziolo

Message:

Editor: Conditionally load registered styles for block variations

In WordPress 5.8 we added the ability to only load styles for blocks when these blocks are rendered. However, these optimizations left out block-styles that get added using the register_block_style() function/API.

Props aristath.
Fixes #53616.

File:

• trunk/src/wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-includes/script-loader.php

@@ -2437 +2437 @@
         $block_styles = WP_Block_Styles_Registry::get_instance()->get_all_registered();
 
-        foreach ( $block_styles as $styles ) {
+        foreach ( $block_styles as $block_name => $styles ) {
                 foreach ( $styles as $style_properties ) {
                         if ( isset( $style_properties['style_handle'] ) ) {
-                                wp_enqueue_style( $style_properties['style_handle'] );
+
+                                // If the site loads separate styles per-block, enqueue the stylesheet on render.
+                                if ( wp_should_load_separate_core_block_assets() ) {
+                                        add_filter(
+                                                'render_block',
+                                                function( $html, $block ) use ( $style_properties ) {
+                                                        wp_enqueue_style( $style_properties['style_handle'] );
+                                                        return $html;
+                                                }
+                                        );
+                                } else {
+                                        wp_enqueue_style( $style_properties['style_handle'] );
+                                }
                         }
                         if ( isset( $style_properties['inline_style'] ) ) {
-                                wp_add_inline_style( 'wp-block-library', $style_properties['inline_style'] );
+
+                                // Default to "wp-block-library".
+                                $handle = 'wp-block-library';
+
+                                // If the site loads separate styles per-block, check if the block has a stylesheet registered.
+                                if ( wp_should_load_separate_core_block_assets() ) {
+                                        $block_stylesheet_handle = generate_block_asset_handle( $block_name, 'style' );
+                                        global $wp_styles;
+                                        if ( isset( $wp_styles->registered[ $block_stylesheet_handle ] ) ) {
+                                                $handle = $block_stylesheet_handle;
+                                        }
+                                }
+
+                                // Add inline styles to the calculated handle.
+                                wp_add_inline_style( $handle, $style_properties['inline_style'] );
                         }
                 }