Changeset 51507 for branches/5.8/src/wp-admin/includes/ajax-actions.php

Timestamp:

07/28/2021 01:01:32 PM (3 years ago)

Author:

desrosj

Message:

Media: Check the posts_per_page value in wp_ajax_query_attachments() before using it as a divisor.

This avoids a "Division by zero" PHP warning if a plugin changes the posts_per_page value to zero.

Follow-up to [51145].

Props 2linctools, kapilpaul, audrasjb, SergeyBiryukov.
Merges [51485] to the 5.8 branch.
Fixes #53773.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/ajax-actions.php (modified) (1 diff)

branches/5.8/src/wp-admin/includes/ajax-actions.php

@@ -3004 +3004 @@
     }
 
-    $max_pages = ceil( $total_posts / (int) $attachments_query->query['posts_per_page'] );
+    $posts_per_page = (int) $attachments_query->query['posts_per_page'];
+
+    $max_pages = $posts_per_page ? ceil( $total_posts / $posts_per_page ) : 0;
 
     header( 'X-WP-Total: ' . (int) $total_posts );