Changeset 51515

Timestamp:

07/30/2021 12:20:38 PM (4 years ago)

Author:

desrosj

Message:

I18n: Fix broken loop in WP_Theme_JSON_Resolver

Related issue in Gutenberg: ​https://github.com/WordPress/gutenberg/issues/33552.

The loop in WP_Theme_JSON_Resolver to extract translatable paths was broken, as it contained an immediate and unconditional return. This caused the loop to immediately exit again after the first iteration, thus never actually looping.

Follow-up to [50959].

Props schlessera.
Merges [51472] to the 5.8 branch.
Fixes #53738.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-theme-json-resolver.php (modified) (1 diff)

branches/5.8/src/wp-includes/class-wp-theme-json-resolver.php

@@ -122 +122 @@
             if ( is_numeric( $property ) ) {
                 foreach ( $partial_child as $key => $context ) {
-                    return array(
-                        array(
-                            'path'    => $current_path,
-                            'key'     => $key,
-                            'context' => $context,
-                        ),
+                    $result[] = array(
+                        'path'    => $current_path,
+                        'key'     => $key,
+                        'context' => $context,
                     );
                 }
+                return $result;
             }
             $result = array_merge(