Changeset 51524 for trunk/tests/phpunit/tests/option/themeMods.php

Timestamp:

08/01/2021 02:54:52 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Themes: Make sure get_theme_mods() always returns an array.

This avoids a "Cannot access offset of type string on string" fatal error in set_theme_mod() on PHP 8 if the theme_mods_$theme_slug option has an incorrect value, e.g. an empty string instead of an array.

With this change, set_theme_mod() should be able to resolve the issue by saving a correct value.

Follow-up to [15736], [15739], [30672], [32629], [32632].

Props xknown.
See #51423.

File:

• trunk/tests/phpunit/tests/option/themeMods.php (modified) (1 diff)

trunk/tests/phpunit/tests/option/themeMods.php

@@ -18 +18 @@
         set_theme_mod( 'test_name', $expected );
         $this->assertSame( $expected, get_theme_mod( 'test_name' ) );
+    }
+
+    /**
+     * @ticket 51423
+     */
+    function test_theme_mod_set_with_invalid_theme_mods_option() {
+        $theme_slug = get_option( 'stylesheet' );
+        update_option( 'theme_mods_' . $theme_slug, '' );
+        self::test_theme_mod_set();
     }