Changeset 51528

Timestamp:

08/02/2021 08:54:44 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Store correct result when bulk updating plugins or themes.

This ensures that when multiple plugins or themes are updated and one succeeds and another fails, the error is reported accordingly.

Previously, both updates would end up treated as a success, due to $this->result containing the result of the previous operation and not the current one.

Follow-up to [12097].

Props pwtyler, afragen.
Fixes #53002.

Location:

trunk/src/wp-admin/includes

Files:

• class-plugin-upgrader.php (modified) (1 diff)
• class-theme-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-plugin-upgrader.php

@@ -348 +348 @@
                         );
 
-                        $results[ $plugin ] = $this->result;
+                        $results[ $plugin ] = $result;
 
                         // Prevent credentials auth screen from displaying multiple times.

trunk/src/wp-admin/includes/class-theme-upgrader.php

@@ -449 +449 @@
                         );
 
-                        $results[ $theme ] = $this->result;
+                        $results[ $theme ] = $result;
 
                         // Prevent credentials auth screen from displaying multiple times.