Changeset 51531

Timestamp:

08/03/2021 11:07:28 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Silence the deprecation warnings for missing return type in WP_REST_Request.

This fixes the "Deprecated: Return type of WP_REST_Request::[METHODNAME]($offset) should be compatible with ArrayAccess::[METHODNAME](): type" warnings on PHP 8.1.

PHP native interfaces now have declared return types and methods in classes implementing these interfaces need to either have the return type declared (in a covariant compatible manner with the PHP native interface method declaration), or need to silence the deprecation warning using the #[ReturnTypeWillChange] attribute.

Follow-up to [51517], [51529], [51530].

Props jrf.
See #53635.

File:

• trunk/src/wp-includes/rest-api/class-wp-rest-request.php (modified) (4 diffs)

trunk/src/wp-includes/rest-api/class-wp-rest-request.php

@@ -958 +958 @@
          * @return bool Whether the parameter is set.
          */
+        #[ReturnTypeWillChange]
         public function offsetExists( $offset ) {
                 $order = $this->get_parameter_order();
@@ -978 +979 @@
          * @return mixed|null Value if set, null otherwise.
          */
+        #[ReturnTypeWillChange]
         public function offsetGet( $offset ) {
                 return $this->get_param( $offset );
@@ -990 +992 @@
          * @param mixed  $value  Parameter value.
          */
+        #[ReturnTypeWillChange]
         public function offsetSet( $offset, $value ) {
                 $this->set_param( $offset, $value );
@@ -1001 +1004 @@
          * @param string $offset Parameter name.
          */
+        #[ReturnTypeWillChange]
         public function offsetUnset( $offset ) {
                 $order = $this->get_parameter_order();