Changeset 51564 for trunk/tests/phpunit/tests/ajax/MediaEdit.php

Timestamp:

08/06/2021 09:45:32 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Replace assertFileNotExists() with assertFileDoesNotExist().

The assertFileNotExists() method was hard deprecated in PHPUnit 9.1 and the functionality will be removed in PHPUnit 10.0.

The assertFileDoesNotExist() method was introduced as a replacement in PHPUnit 9.1.

This new PHPUnit method is polyfilled by the PHPUnit Polyfills and switching to it will future-proof the tests some more.

References:

• ​https://github.com/sebastianbergmann/phpunit/blob/9.1.5/ChangeLog-9.1.md#910---2020-04-03
• ​https://github.com/sebastianbergmann/phpunit/issues/4076

Follow-up to [51559-51563].

Props jrf.
See #46149.

File:

• trunk/tests/phpunit/tests/ajax/MediaEdit.php (modified) (1 diff)

trunk/tests/phpunit/tests/ajax/MediaEdit.php

@@ -97 +97 @@
 
         foreach ( $files_that_shouldnt_exist as $file ) {
-            $this->assertFileNotExists( $file, 'IMAGE_EDIT_OVERWRITE is leaving garbage image files behind.' );
+            $this->assertFileDoesNotExist( $file, 'IMAGE_EDIT_OVERWRITE is leaving garbage image files behind.' );
         }
     }