Changeset 51568 for trunk/tests/phpunit/tests/dbdelta.php

Timestamp:

08/07/2021 10:29:41 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Implement use of the void solution.

PHPUnit 8.0.0 introduced a void return type declaration to the "fixture" methods – setUpBeforeClass(), setUp(), tearDown() and tearDownAfterClass(). As the void return type was not introduced until PHP 7.1, this makes it more difficult to create cross-version compatible tests when using fixtures, due to signature mismatches.

The Yoast\PHPUnitPolyfills\TestCases\TestCase overcomes the signature mismatch by having two versions. The correct one will be loaded depending on the PHPUnit version being used.

When using this TestCase, if an individual test, or another TestCase which extends this TestCase, needs to overload any of the "fixture" methods, it should do so by using a snake_case variant of the original fixture method name, i.e. set_up_before_class(), set_up(), assert_pre_conditions(), assert_post_conditions(), tear_down(), and tear_down_after_class().

The snake_case methods will automatically be called by PHPUnit.

IMPORTANT: The snake_case methods should not call the PHPUnit parent, i.e. do not use parent::setUp() from within an overloaded set_up() method. If necessary, DO call parent::set_up().

Reference: ​https://github.com/Yoast/PHPUnit-Polyfills#testcases

This commit renames all declared fixture methods, and calls to parent versions of those fixture methods, from camelCase to snake_case.

Follow-up to [51559-51567].

Props jrf, hellofromTonya, johnbillion, netweb, dd32, pputzer, SergeyBiryukov.
See #46149.

File:

• trunk/tests/phpunit/tests/dbdelta.php (modified) (4 diffs)

trunk/tests/phpunit/tests/dbdelta.php

@@ -33 +33 @@
      * Make sure the upgrade code is loaded before the tests are run.
      */
-    public static function setUpBeforeClass() {
-
-        parent::setUpBeforeClass();
+    public static function set_up_before_class() {
+
+        parent::set_up_before_class();
 
         require_once ABSPATH . 'wp-admin/includes/upgrade.php';
@@ -43 +43 @@
      * Create a custom table to be used in each test.
      */
-    public function setUp() {
+    public function set_up() {
 
         global $wpdb;
@@ -82 +82 @@
         // This has to be called after the `CREATE TABLE` above as the `_create_temporary_tables` filter
         // causes it to create a temporary table, and a temporary table cannot use a FULLTEXT index.
-        parent::setUp();
+        parent::set_up();
     }
 
@@ -88 +88 @@
      * Delete the custom table on teardown.
      */
-    public function tearDown() {
-
-        global $wpdb;
-
-        parent::tearDown();
+    public function tear_down() {
+
+        global $wpdb;
+
+        parent::tear_down();
 
         // This has to be called after the parent `tearDown()` method.