WordPress.org

Make WordPress Core

Changeset 51571


Ignore:
Timestamp:
08/07/2021 10:51:59 AM (3 months ago)
Author:
SergeyBiryukov
Message:

Tests: Fix tests failing due to assertContains() using strict checking.

Since PHPUnit 8.0.2, the assertContains() method, when checking whether a value exists in an array, will do a strict type comparison of the values.

This caused a couple of tests to fail. Using the correct data type in the test fixes that.

References:

Follow-up to [51559-51570].

Props jrf.
See #46149.

Location:
trunk/tests/phpunit/tests
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/comment/getPageOfComment.php

    r50559 r51571  
    486486        remove_filter( 'wp_get_current_commenter', array( $this, 'get_current_commenter' ) );
    487487
    488         $this->assertContains( $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
     488        $this->assertContains( (string) $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
    489489    }
    490490
     
    543543        );
    544544
    545         $this->assertContains( $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
     545        $this->assertContains( (string) $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
    546546
    547547        wp_set_current_user( $current_user );
  • trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php

    r51568 r51571  
    892892        $this->assertNotEmpty( $meta );
    893893        $this->assertCount( 2, $meta );
    894         $this->assertContains( 2, $meta );
    895         $this->assertContains( 8, $meta );
     894        $this->assertContains( '2', $meta );
     895        $this->assertContains( '8', $meta );
    896896    }
    897897
  • trunk/tests/phpunit/tests/rest-api/rest-term-meta-fields.php

    r51568 r51571  
    839839        $this->assertNotEmpty( $meta );
    840840        $this->assertCount( 2, $meta );
    841         $this->assertContains( 2, $meta );
    842         $this->assertContains( 8, $meta );
     841        $this->assertContains( '2', $meta );
     842        $this->assertContains( '8', $meta );
    843843    }
    844844
Note: See TracChangeset for help on using the changeset viewer.