Changeset 51571 for trunk/tests/phpunit/tests/comment/getPageOfComment.php

Timestamp:

08/07/2021 10:51:59 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Fix tests failing due to assertContains() using strict checking.

Since PHPUnit 8.0.2, the assertContains() method, when checking whether a value exists in an array, will do a strict type comparison of the values.

This caused a couple of tests to fail. Using the correct data type in the test fixes that.

References:

• ​https://github.com/sebastianbergmann/phpunit/blob/8.0.6/ChangeLog-8.0.md#802---2019-02-07
• ​https://github.com/sebastianbergmann/phpunit/issues/3511
• ​https://github.com/sebastianbergmann/phpunit/commit/6205f335954d00fa01992fe324a7eefbc954449e

Follow-up to [51559-51570].

Props jrf.
See #46149.

File:

• trunk/tests/phpunit/tests/comment/getPageOfComment.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/getPageOfComment.php

@@ -486 +486 @@
         remove_filter( 'wp_get_current_commenter', array( $this, 'get_current_commenter' ) );
 
-        $this->assertContains( $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
+        $this->assertContains( (string) $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
     }
 
@@ -543 +543 @@
         );
 
-        $this->assertContains( $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
+        $this->assertContains( (string) $new_unapproved, wp_list_pluck( $comments, 'comment_ID' ) );
 
         wp_set_current_user( $current_user );