Changeset 51572

Timestamp:

08/07/2021 11:00:52 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Handle removal of TestCase::getAnnotations().

The PHPUnit native TestCase::getAnnotations() method is used to check for WP flavored deprecation notices, however, this method was not covered by the backward compatibility promise for PHPUnit (and was annotated as excluded).

The method has been removed as part of an internal refactor in commit ​sebastianbergmann/phpunit@6858204, which is included in PHPUnit 9.5.0.

For now, a workaround is put in place, but it is recommended that the WP expectDeprecated() method should be reevaluated in a future iteration.

Follow-up to [51559-51571].

Props jrf.
See #46149.

File:

• trunk/tests/phpunit/includes/abstract-testcase.php (modified) (1 diff)

trunk/tests/phpunit/includes/abstract-testcase.php

@@ -473 +473 @@
      */
     public function expectDeprecated() {
-        $annotations = $this->getAnnotations();
+        if ( method_exists( $this, 'getAnnotations' ) ) {
+            // PHPUnit < 9.5.0.
+            $annotations = $this->getAnnotations();
+        } else {
+            // PHPUnit >= 9.5.0.
+            $annotations = \PHPUnit\Util\Test::parseTestMethodAnnotations(
+                static::class,
+                $this->getName( false )
+            );
+        }
+
         foreach ( array( 'class', 'method' ) as $depth ) {
             if ( ! empty( $annotations[ $depth ]['expectedDeprecated'] ) ) {