Changeset 51580

Timestamp:

08/07/2021 02:18:31 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more appropriate assertions in get_themes() tests.

This replaces instances of assertTrue( is_dir( ... ) ) with assertDirectoryExists() to use native PHPUnit functionality.

The assertDirectoryExists() method was introduced in PHPUnit 5.6. As the minimum supported PHPUnit version has been raised to PHPUnit 5.7.21, it can now be used.

Follow-up to [51543], [51574], [51579].

Props jrf.
See #53363.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme.php

@@ -159 +159 @@
             }
 
-            $this->assertTrue( is_dir( $dir . $theme['Template Dir'] ) );
-            $this->assertTrue( is_dir( $dir . $theme['Stylesheet Dir'] ) );
+            $this->assertDirectoryExists( $dir . $theme['Template Dir'] );
+            $this->assertDirectoryExists( $dir . $theme['Stylesheet Dir'] );
 
             $this->assertSame( 'publish', $theme['Status'] );