Changeset 51582

Timestamp:

08/08/2021 02:08:15 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Set the MySQLi error reporting off for PHP 8.1.

Prior to PHP 8.1, the default error handling mode was MYSQLI_REPORT_OFF. An error in the extension, database, query, or the database connection returned false and emitted a PHP warning:

$mysqli = new mysqli("localhost", "non-existing-user", "", "");

Warning: mysqli::__construct(): (HY000/2002): No connection could be made because the target machine actively refused it in ... on line ...

From PHP 8.1 and later, the default error mode is set to MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT. An error in the extension, database, query, or the database connection throws an exception:

$mysqli = new mysqli("localhost", "non-existing-user", "", "");

Fatal error: Uncaught mysqli_sql_exception: Connection refused in ...:...

WordPress has its own error reporting and gracefully handles the database errors by inspecting the error codes. Setting the MySQLi error reporting to off avoids fatal errors due to uncaught exceptions and maintains the current behavior.

References:

• ​PHP 8.1: MySQLi: Default error mode set to exceptions
• ​PHP RFC: Change Default mysqli Error Mode

Props ayeshrajans, jrf.
Fixes #52825.

File:

• trunk/src/wp-includes/wp-db.php (modified) (1 diff)

trunk/src/wp-includes/wp-db.php

@@ -1628 +1628 @@
 
         if ( $this->use_mysqli ) {
+            /*
+             * Set the MySQLi error reporting off because WordPress handles its own.
+             * This is due to the default value change from `MYSQLI_REPORT_OFF`
+             * to `MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT` in PHP 8.1.
+             */
+            mysqli_report( MYSQLI_REPORT_OFF );
+
             $this->dbh = mysqli_init();