Changeset 51619 for trunk/src/wp-includes/cron.php

Timestamp:

08/16/2021 03:22:38 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Check the return type of _get_cron_array() in wp_schedule_event().

This fixes a "Deprecated: Automatic conversion of false to array is deprecated" warning on PHP 8.1.

In wp_schedule_event(), the cron info array is retrieved via a call to _get_cron_array(), but as the documentation (correctly) states, the return type of that function is array|false, where false is returned for a virgin site, with no cron jobs scheduled yet.

However, no type check is done on the return value, and the wp_schedule_event() function just blindly continues by assigning a value to a subkey of the $crons "array".

Fixed by adding validation for the returned value from _get_cron_array() and initializing an empty array if false was returned.

Reference: ​WordPress Developer Resources: _get_cron_array()

Props jrf, hellofromTonya, lucatume, pbearne, iluy, pedromendonca, SergeyBiryukov.
See #53635.

File:

• trunk/src/wp-includes/cron.php (modified) (2 diffs)

trunk/src/wp-includes/cron.php

@@ -303 +303 @@
 
         $crons = _get_cron_array();
+        if ( ! is_array( $crons ) ) {
+                $crons = array();
+        }
+
         $crons[ $event->timestamp ][ $event->hook ][ $key ] = array(
                 'schedule' => $event->schedule,
@@ -1126 +1130 @@
 
         $crons = _get_cron_array();
-
-        if ( false === $crons ) {
+        if ( ! is_array( $crons ) ) {
                 return array();
         }