Changeset 51625

Timestamp:

08/16/2021 10:51:47 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Check the input type in validate_file().

This fixes a preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated notice on PHP 8.1.

The behavior for null and string input is covered by the existing Tests_Functions::test_validate_file() test.

Effect: Errors down by 238, assertions up by 1920, failures down by 1.

Props jrf, hellofromTonya, SergeyBiryukov.
See #53635.

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -5710 +5710 @@
  */
 function validate_file( $file, $allowed_files = array() ) {
+    if ( ! is_scalar( $file ) || '' === $file ) {
+        return 0;
+    }
+
     // `../` on its own is not allowed:
     if ( '../' === $file ) {