Changeset 51640

Timestamp:

08/19/2021 01:45:18 PM (3 years ago)

Author:

desrosj

Message:

Customize: Hide native control on background position field.

Hide the browser's native radio button on the custom background position selector in the Customizer and the legacy background screen. This fixes an issue causing both to display.

Props mukesh27, ravipatel, sabernhardt, walbo, peterwilsoncc.
Merges [51637] to the 5.8 branch.
Fixes #53803.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-custom-background.php (modified) (1 diff)
• src/wp-includes/customize/class-wp-customize-background-position-control.php (modified) (1 diff)

branches/5.8/src/wp-admin/includes/class-custom-background.php

@@ -419 +419 @@
                 <?php foreach ( $group as $value => $input ) : ?>
         <label>
-            <input class="screen-reader-text" name="background-position" type="radio" value="<?php echo esc_attr( $value ); ?>"<?php checked( $value, $background_position ); ?>>
+            <input class="ui-helper-hidden-accessible" name="background-position" type="radio" value="<?php echo esc_attr( $value ); ?>"<?php checked( $value, $background_position ); ?>>
             <span class="button display-options position"><span class="<?php echo esc_attr( $input['icon'] ); ?>" aria-hidden="true"></span></span>
             <span class="screen-reader-text"><?php echo $input['label']; ?></span>

branches/5.8/src/wp-includes/customize/class-wp-customize-background-position-control.php

@@ -97 +97 @@
                     <?php foreach ( $group as $value => $input ) : ?>
                         <label>
-                            <input class="screen-reader-text" name="background-position" type="radio" value="<?php echo esc_attr( $value ); ?>">
+                            <input class="ui-helper-hidden-accessible" name="background-position" type="radio" value="<?php echo esc_attr( $value ); ?>">
                             <span class="button display-options position"><span class="<?php echo esc_attr( $input['icon'] ); ?>" aria-hidden="true"></span></span>
                             <span class="screen-reader-text"><?php echo $input['label']; ?></span>