Changeset 51678 for trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

Timestamp:

08/27/2021 03:42:36 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Display a message on Plugins list table if a plugin requires a higher version of PHP or WordPress.

Installation and activation of incompatible plugins was previously disallowed in [43436] and [44978], but if such a plugin was installed manually, there was nothing on the Plugins screen that would show its compatibility status.

Showing an appropriate notice with a documentation link makes the UI more consistent and improves user experience.

Follow-up to [43436], [44937], [44939], [44978], [45043], [45165], [45546], [47573], [47816], [47819], [48172], [48636], [48637], [48638], [48640], [48652], [48653], [48654], [48660].

Props TacoVerdo, SergeyBiryukov.
Fixes #53990.

File:

• trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -587 +587 @@
                                                         );
                                                 } elseif ( current_user_can( 'activate_plugin', $status['file'] ) ) {
-                                                        $button_text = __( 'Activate' );
-                                                        /* translators: %s: Plugin name. */
-                                                        $button_label = _x( 'Activate %s', 'plugin' );
-                                                        $activate_url = add_query_arg(
-                                                                array(
-                                                                        '_wpnonce' => wp_create_nonce( 'activate-plugin_' . $status['file'] ),
-                                                                        'action'   => 'activate',
-                                                                        'plugin'   => $status['file'],
-                                                                ),
-                                                                network_admin_url( 'plugins.php' )
-                                                        );
-
-                                                        if ( is_network_admin() ) {
-                                                                $button_text = __( 'Network Activate' );
+                                                        if ( $compatible_php && $compatible_wp ) {
+                                                                $button_text = __( 'Activate' );
                                                                 /* translators: %s: Plugin name. */
-                                                                $button_label = _x( 'Network Activate %s', 'plugin' );
-                                                                $activate_url = add_query_arg( array( 'networkwide' => 1 ), $activate_url );
+                                                                $button_label = _x( 'Activate %s', 'plugin' );
+                                                                $activate_url = add_query_arg(
+                                                                        array(
+                                                                                '_wpnonce' => wp_create_nonce( 'activate-plugin_' . $status['file'] ),
+                                                                                'action'   => 'activate',
+                                                                                'plugin'   => $status['file'],
+                                                                        ),
+                                                                        network_admin_url( 'plugins.php' )
+                                                                );
+
+                                                                if ( is_network_admin() ) {
+                                                                        $button_text = __( 'Network Activate' );
+                                                                        /* translators: %s: Plugin name. */
+                                                                        $button_label = _x( 'Network Activate %s', 'plugin' );
+                                                                        $activate_url = add_query_arg( array( 'networkwide' => 1 ), $activate_url );
+                                                                }
+
+                                                                $action_links[] = sprintf(
+                                                                        '<a href="%1$s" class="button activate-now" aria-label="%2$s">%3$s</a>',
+                                                                        esc_url( $activate_url ),
+                                                                        esc_attr( sprintf( $button_label, $plugin['name'] ) ),
+                                                                        $button_text
+                                                                );
+                                                        } else {
+                                                                $action_links[] = sprintf(
+                                                                        '<button type="button" class="button button-disabled" disabled="disabled">%s</button>',
+                                                                        _x( 'Cannot Activate', 'plugin' )
+                                                                );
                                                         }
-
-                                                        $action_links[] = sprintf(
-                                                                '<a href="%1$s" class="button activate-now" aria-label="%2$s">%3$s</a>',
-                                                                esc_url( $activate_url ),
-                                                                esc_attr( sprintf( $button_label, $plugin['name'] ) ),
-                                                                $button_text
-                                                        );
                                                 } else {
                                                         $action_links[] = sprintf(