Changeset 51695

Timestamp:

08/30/2021 03:19:38 PM (3 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Add input validation to _set_cron_array().

The private _set_cron_array() function expects a cron array as the first parameter, but will often be passed the - potentially updated - output of a call to _get_cron_array().

When the _get_cron_array() function returns false, a "Deprecated: Automatic conversion of false to array is deprecated" warning will be thrown on PHP 8.1.

The input validation resolves the deprecation warning by setting the cron value to an empty array when not given an array data type.

Adds a full set of _set_cron_array() tests.

Follow-up to [4189], [50152].

Props jrf, hellofromTonya, peterwilsoncc.
See #53635.

Location:

trunk

Files:

• src/wp-includes/cron.php (modified) (1 diff)
• tests/phpunit/tests/cron (added)
• tests/phpunit/tests/cron/setCronArray.php (added)

trunk/src/wp-includes/cron.php

@@ -1192 +1192 @@
  */
 function _set_cron_array( $cron, $wp_error = false ) {
+    if ( ! is_array( $cron ) ) {
+        $cron = array();
+    }
+
     $cron['version'] = 2;
     $result          = update_option( 'cron', $cron );