Changeset 51705 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

Timestamp:

08/31/2021 07:57:20 PM (3 years ago)

Author:

hellofromTonya

Message:

Widgets: Rename and soft deprecate retrieve_widgets().

The original name retrieve_widgets() was unclear as it suggested it was a getter, i.e. getting the widgets. This function does more than get: finds orphaned widgets, assigns them to the inactive sidebar, and updates the database.

The new name is sync_registered_widgets() which better represents what happens when this function is invoked.

The original retrieve_widgets() function is soft deprecated to avoid unnecessary code churn downstream for developers that support more than the latest version of WordPress.

Follow-up to [18630].

Props zieladam, timothyblynjacobs, andraganescu, hellofromTonya.
See #53811.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

@@ -99 +99 @@
      */
     public function get_items( $request ) {
-        retrieve_widgets();
+        sync_registered_widgets();
 
         $data = array();
@@ -138 +138 @@
      */
     public function get_item( $request ) {
-        retrieve_widgets();
+        sync_registered_widgets();
 
         $sidebar = $this->get_sidebar( $request['id'] );