Changeset 51735 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

09/07/2021 06:18:10 PM (4 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix parameter name mismatches for parent/child classes in WP_List_Table::column_cb().

Matches the method signatures of the parent class and each child class.

Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

For readability:

• @since clearly specifies the original parameter name and its new name as well as why the change happened

• in methods longer than a single line, the generic parameter is reassigned to the original parameter restoring it for context for use within the method. An inline comment is added to explain why this reassignment is made.

Follow-up to [15632], [30679], [31210], [32740], [32753], [32754], [32755], [32756], [32757].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -506 +506 @@
      *
      * @since 4.3.0
-     *
-     * @param WP_Theme $theme The current WP_Theme object.
-     */
-    public function column_cb( $theme ) {
+     * @since 5.9.0 Renamed `$theme` to `$item` to match parent class for PHP 8 named parameter support.
+     *
+     * @param WP_Theme $item The current WP_Theme object.
+     */
+    public function column_cb( $item ) {
+        // Restores the more descriptive, specific name for use within this method.
+        $theme       = $item;
         $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
         ?>