Make WordPress Core


Ignore:
Timestamp:
09/07/2021 07:23:00 PM (2 years ago)
Author:
hellofromTonya
Message:

Code Modernization: Fix parameter name mismatches for parent/child classes in WP_List_Table::handle_row_actions().

Matches the method signatures of the parent class and each child class.

Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

For readability:

  • @since clearly specifies the original parameter name and its new name as well as why the change happened
  • in methods longer than a single line, the generic parameter is reassigned to the original parameter restoring it for context for use within the method. An inline comment is added to explain why this reassignment is made.

Follow-up to [32644], [32664], [32798], [38489], [49183], [49197].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-comments-list-table.php

    r51735 r51737  
    652652     *
    653653     * @since 4.3.0
     654     * @since 5.9.0 Renamed `$comment` to `$item` to match parent class for PHP 8 named parameter support.
    654655     *
    655656     * @global string $comment_status Status for the current listed comments.
    656657     *
    657      * @param WP_Comment $comment     The comment object.
     658     * @param WP_Comment $item        The comment object.
    658659     * @param string     $column_name Current column name.
    659660     * @param string     $primary     Primary column name.
     
    662663     *                or if the current user cannot edit the comment.
    663664     */
    664     protected function handle_row_actions( $comment, $column_name, $primary ) {
     665    protected function handle_row_actions( $item, $column_name, $primary ) {
    665666        global $comment_status;
    666667
     
    673674        }
    674675
     676        // Restores the more descriptive, specific name for use within this method.
     677        $comment            = $item;
    675678        $the_comment_status = wp_get_comment_status( $comment );
    676679
Note: See TracChangeset for help on using the changeset viewer.