Changeset 51737 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

09/07/2021 07:23:00 PM (3 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix parameter name mismatches for parent/child classes in WP_List_Table::handle_row_actions().

Matches the method signatures of the parent class and each child class.

Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

For readability:

• @since clearly specifies the original parameter name and its new name as well as why the change happened

• in methods longer than a single line, the generic parameter is reassigned to the original parameter restoring it for context for use within the method. An inline comment is added to explain why this reassignment is made.

Follow-up to [32644], [32664], [32798], [38489], [49183], [49197].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -828 +828 @@
      *
      * @since 4.3.0
-     *
-     * @param WP_Post $post        Attachment being acted upon.
+     * @since 5.9.0 Renamed `$post` to `$item` to match parent class for PHP 8 named parameter support.
+     *
+     * @param WP_Post $item        Attachment being acted upon.
      * @param string  $column_name Current column name.
      * @param string  $primary     Primary column name.
@@ -835 +836 @@
      *                if the current column is not the primary column.
      */
-    protected function handle_row_actions( $post, $column_name, $primary ) {
+    protected function handle_row_actions( $item, $column_name, $primary ) {
         if ( $primary !== $column_name ) {
             return '';
@@ -841 +842 @@
 
         $att_title = _draft_or_post_title();
-
-        return $this->row_actions( $this->_get_row_actions( $post, $att_title ) );
+        $actions   = $this->_get_row_actions(
+            $item, // WP_Post object for an attachment.
+            $att_title
+        );
+
+        return $this->row_actions( $actions );
     }
 }