Make WordPress Core

09/09/2021 12:38:36 PM (6 weeks ago)

Code Modernization: Fix last parameter name mismatches for parent/child classes in Walker::start_el().

The parent class uses $current_object_id while most of the child classes use $id. As the parent class' is more descriptive, renaming the last parameter in each of child class.

Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

Changes for readability:

  • @since clearly specifies the original parameter name and its new name as well as why the change happened.
  • In methods longer than a single line, the generic parameter is reassigned to the original parameter restoring it for context for use within the method. An inline comment is added to explain why this reassignment is made.
  • In cases where the original parameter name was too generic or misleading, renamed (when reassigning) to a more descriptive name for use within the method.

Follow-up to [7737], [8900], [8970], [14248], [15077], [16100], [25642], [25644], [37051], [37054], [37056], [46271], [47189], [51739].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.

1 edited


  • trunk/src/wp-includes/class-wp-walker.php

    r51739 r51779  
    9191     * @param int    $depth             Depth of the item.
    9292     * @param array  $args              An array of additional arguments.
    93      * @param int    $current_object_id ID of the current item.
     93     * @param int    $current_object_id Optional. ID of the current item. Default 0.
    9494     */
    9595    public function start_el( &$output, $data_object, $depth = 0, $args = array(), $current_object_id = 0 ) {}
Note: See TracChangeset for help on using the changeset viewer.