Changeset 51782 for trunk/src/wp-admin/includes/class-language-pack-upgrader-skin.php

Timestamp:

09/09/2021 01:58:25 PM (4 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Upgrader_Skin::error().

In each child class: renames the parameter to match the parent's method signature.

Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

Changes for readability:

• @since clearly specifies the original parameter name and its new name as well as why the change happened.

Follow-up to [11005], [25806], [32655], [38199].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.

File:

• trunk/src/wp-admin/includes/class-language-pack-upgrader-skin.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-language-pack-upgrader-skin.php

@@ -53 +53 @@
 
     /**
-     * @param string|WP_Error $error
+     * @since 5.9.0 Renamed `$error` to `$errors` for PHP 8 named parameter support.
+     *
+     * @param string|WP_Error $errors Errors.
      */
-    public function error( $error ) {
+    public function error( $errors ) {
         echo '<div class="lp-error">';
-        parent::error( $error );
+        parent::error( $errors );
         echo '</div>';
     }