Changeset 51791 for trunk/src/wp-includes/class-wp-customize-widgets.php

Timestamp:

09/09/2021 09:39:39 PM (5 years ago)

Author:

hellofromTonya

Message:

Widgets: Revert [51705].

While the new name is much better, it doesn't fully tell what will happen when invoked nor does it fully solve the root problems.

Why? The function is doing too much. And naming is hard.

Props azaozz, desrosj, andraganescu, zieladam, hellofromTonya.
See #53811.

File:

• trunk/src/wp-includes/class-wp-customize-widgets.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-customize-widgets.php

@@ -276 +276 @@
                 $this->manager->set_post_value( 'old_sidebars_widgets_data', $this->old_sidebars_widgets ); // Override any value cached in changeset.
 
-                // sync_registered_widgets() looks at the global $sidebars_widgets.
+                // retrieve_widgets() looks at the global $sidebars_widgets.
                 $sidebars_widgets = $this->old_sidebars_widgets;
-                $sidebars_widgets = sync_registered_widgets( 'customize' );
+                $sidebars_widgets = retrieve_widgets( 'customize' );
                 add_filter( 'option_sidebars_widgets', array( $this, 'filter_option_sidebars_widgets_for_theme_switch' ), 1 );
                 // Reset global cache var used by wp_get_sidebars_widgets().
@@ -288 +288 @@
          *
          * When switching themes, filter the Customizer setting old_sidebars_widgets_data
-         * to supply initial $sidebars_widgets before they were overridden by sync_registered_widgets().
+         * to supply initial $sidebars_widgets before they were overridden by retrieve_widgets().
          * The value for old_sidebars_widgets_data gets set in the old theme's sidebars_widgets
          * theme_mod.
@@ -306 +306 @@
          * Filters sidebars_widgets option for theme switch.
          *
-         * When switching themes, the sync_registered_widgets() function is run when the Customizer initializes,
+         * When switching themes, the retrieve_widgets() function is run when the Customizer initializes,
          * and then the new sidebars_widgets here get supplied as the default value for the sidebars_widgets
          * option.