Changeset 51791 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

Timestamp:

09/09/2021 09:39:39 PM (3 years ago)

Author:

hellofromTonya

Message:

Widgets: Revert [51705].

While the new name is much better, it doesn't fully tell what will happen when invoked nor does it fully solve the root problems.

Why? The function is doing too much. And naming is hard.

Props azaozz, desrosj, andraganescu, zieladam, hellofromTonya.
See #53811.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php (modified) (6 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

@@ -110 +110 @@
      */
     public function get_items( $request ) {
-        sync_registered_widgets();
+        retrieve_widgets();
 
         $prepared = array();
@@ -152 +152 @@
      */
     public function get_item( $request ) {
-        sync_registered_widgets();
+        retrieve_widgets();
 
         $widget_id  = $request['id'];
@@ -238 +238 @@
 
         /*
-         * sync_registered_widgets() contains logic to move "hidden" or "lost" widgets to the
+         * retrieve_widgets() contains logic to move "hidden" or "lost" widgets to the
          * wp_inactive_widgets sidebar based on the contents of the $sidebars_widgets global.
          *
@@ -249 +249 @@
         wp_get_sidebars_widgets();
 
-        sync_registered_widgets();
+        retrieve_widgets();
 
         $widget_id  = $request['id'];
@@ -314 +314 @@
 
         /*
-         * sync_registered_widgets() contains logic to move "hidden" or "lost" widgets to the
+         * retrieve_widgets() contains logic to move "hidden" or "lost" widgets to the
          * wp_inactive_widgets sidebar based on the contents of the $sidebars_widgets global.
          *
@@ -325 +325 @@
         wp_get_sidebars_widgets();
 
-        sync_registered_widgets();
+        retrieve_widgets();
 
         $widget_id  = $request['id'];