Changeset 51791 for trunk/tests/phpunit/tests/widgets.php

Timestamp:

09/09/2021 09:39:39 PM (3 years ago)

Author:

hellofromTonya

Message:

Widgets: Revert [51705].

While the new name is much better, it doesn't fully tell what will happen when invoked nor does it fully solve the root problems.

Why? The function is doing too much. And naming is hard.

Props azaozz, desrosj, andraganescu, zieladam, hellofromTonya.
See #53811.

File:

• trunk/tests/phpunit/tests/widgets.php (modified) (13 diffs)

trunk/tests/phpunit/tests/widgets.php

@@ -844 +844 @@
      * Tests for when 'sidebars_widgets' theme mod is populated.
      *
-     * @covers ::sync_registered_widgets
-     */
-    function test_sync_registered_widgets_with_theme_mod() {
+     * @covers ::retrieve_widgets
+     */
+    function test_retrieve_widgets_with_theme_mod() {
         global $sidebars_widgets, $_wp_sidebars_widgets;
 
@@ -874 +874 @@
         );
 
-        $result = sync_registered_widgets( true );
+        $result = retrieve_widgets( true );
 
         $this->assertIsArray( $result );
@@ -907 +907 @@
      * Tests for when sidebars widgets matches registered sidebars.
      *
-     * @covers ::sync_registered_widgets
-     */
-    function test_sync_registered_widgets_with_sidebars_widgets_matching_registered_sidebars() {
+     * @covers ::retrieve_widgets
+     */
+    function test_retrieve_widgets_with_sidebars_widgets_matching_registered_sidebars() {
         global $sidebars_widgets;
 
@@ -922 +922 @@
         );
 
-        $result = sync_registered_widgets( true );
+        $result = retrieve_widgets( true );
 
         // $sidebars_widgets matches registered sidebars.
@@ -945 +945 @@
      * Tests for when sidebars widgets doesn't match registered sidebars.
      *
-     * @covers ::sync_registered_widgets
-     */
-    function test_sync_registered_widgets_with_sidebars_widgets_not_matching_registered_sidebars() {
+     * @covers ::retrieve_widgets
+     */
+    function test_retrieve_widgets_with_sidebars_widgets_not_matching_registered_sidebars() {
         global $sidebars_widgets, $_wp_sidebars_widgets;
 
@@ -961 +961 @@
 
         // Theme changed.
-        $result = sync_registered_widgets( true );
+        $result = retrieve_widgets( true );
 
         $_wp_sidebars_widgets = array();
@@ -1003 +1003 @@
 
         // Theme did not change.
-        $result = sync_registered_widgets();
+        $result = retrieve_widgets();
 
         $_wp_sidebars_widgets = array();
@@ -1037 +1037 @@
      * Tests for Customizer mode.
      *
-     * @covers ::sync_registered_widgets
-     */
-    function test_sync_registered_widgets_for_customizer() {
+     * @covers ::retrieve_widgets
+     */
+    function test_retrieve_widgets_for_customizer() {
         global $sidebars_widgets, $_wp_sidebars_widgets;
 
@@ -1054 +1054 @@
         set_theme_mod( 'sidebars_widgets', $old_sidebars_widgets );
 
-        $result = sync_registered_widgets( 'customize' );
+        $result = retrieve_widgets( 'customize' );
 
         $_wp_sidebars_widgets = array();
@@ -1083 +1083 @@
     }
 
-    function test_sync_registered_widgets_with_single_widget() {
+    function test_retrieve_widgets_with_single_widget() {
         global $sidebars_widgets;
 
@@ -1100 +1100 @@
 
         // Theme changed.
-        $result = sync_registered_widgets( true );
+        $result = retrieve_widgets( true );
 
         $this->assertContains( 'single', $result['wp_inactive_widgets'] );
@@ -1108 +1108 @@
      * Tests for orphaned widgets being moved into inactive widgets.
      *
-     * @covers ::sync_registered_widgets
-     */
-    function test_sync_registered_widgets_move_orphaned_widgets_to_inactive() {
+     * @covers ::retrieve_widgets
+     */
+    function test_retrieve_widgets_move_orphaned_widgets_to_inactive() {
         global $sidebars_widgets;
 
@@ -1123 +1123 @@
         );
 
-        sync_registered_widgets();
+        retrieve_widgets();
 
         $this->assertIsArray( $sidebars_widgets );