WordPress.org

Make WordPress Core

Changeset 51793


Ignore:
Timestamp:
09/09/2021 10:55:36 PM (4 months ago)
Author:
hellofromTonya
Message:

Code Modernization: Fix null to non-nullable deprecation in wp_privacy_anonymize_ip().

The wp_privacy_anonymize_ip() function expects a string for the $ip_addr parameter, but did not do any input validation.

One of the pre-existing test cases, passed null to the function, leading to a substr_count(): Passing null to parameter #1 ($haystack) of type string is deprecated notice on PHP 8.1.

Fixed now by doing a cursory check on the variable at the start of the function and bowing out early for a number of cases (null, false, 0, '') which would all result in the same 0.0.0.0 output anyway.

Follow-up [42971].

Props jrf, hellofromTonya.
See #53635.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/functions.php

    r51740 r51793  
    76197619 */
    76207620function wp_privacy_anonymize_ip( $ip_addr, $ipv6_fallback = false ) {
     7621    if ( empty( $ip_addr ) ) {
     7622        return '0.0.0.0';
     7623    }
     7624
    76217625    // Detect what kind of IP address this is.
    76227626    $ip_prefix = '';
Note: See TracChangeset for help on using the changeset viewer.