Changeset 51806

Timestamp:

09/13/2021 06:53:57 PM (3 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix "passing null to non-nullable" deprecation notice in WP_Comment_Query::get_comment_ids().

The WP_Comment_Query::get_comment_ids() method is supposed to handle null as a search query, but was throwing a strlen(): Passing null to parameter #1 ($string) of type string is deprecated notice on PHP 8.1.

Discovered via and already covered via the pre-existing Tests_Comment_Query::test_search_null_should_be_ignored() test method.

Follow-up to [36345], [48275].

Props jrf, hellofromTonya.
See #53635.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -802 +802 @@
 
         // Falsey search strings are ignored.
-        if ( strlen( $this->query_vars['search'] ) ) {
+        if ( isset( $this->query_vars['search'] ) && strlen( $this->query_vars['search'] ) ) {
             $search_sql = $this->get_search_sql(
                 $this->query_vars['search'],