Changeset 51819

Timestamp:

09/16/2021 06:03:04 PM (21 months ago)

Author:

jorgefilipecosta

Message:

Block editor: Cache global stylesheet by theme key.

Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory).
This commit makes sure the stylesheet is regenerated upon switching themes.

Props oandregal, dd32.
See #53175.

File:

• trunk/src/wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-includes/script-loader.php

@@ -2301 +2301 @@
 
     $stylesheet = null;
+    $transient_name = 'global_styles_' . get_stylesheet();
     if ( $can_use_cache ) {
-        $cache = get_transient( 'global_styles' );
+        $cache = get_transient( $transient_name );
         if ( $cache ) {
             $stylesheet = $cache;
@@ -2314 +2315 @@
 
         if ( $can_use_cache ) {
-            set_transient( 'global_styles', $stylesheet, MINUTE_IN_SECONDS );
+            set_transient( $transient_name, $stylesheet, MINUTE_IN_SECONDS );
         }
     }