Changeset 51829 for trunk/src/wp-login.php

Timestamp:

09/20/2021 06:21:32 PM (3 years ago)

Author:

hellofromTonya

Message:

Login and Registration: Fix "passing null to non-nullable" deprecation for authorize_application error message.

If there is no URL query in the $_GET['redirect_to'], wp_parse_url() will return null. Passing null to parse_str()` results in a PHP 8.1 deprecation notice

Deprecated: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated

This commit:

• Fixes the deprecation notice.
• Skips doing the parse_str() when there's no URL query.
• Provides a micro-optimization performance boost.

Follow-up to [49109].

Props jrf, hellofromTonya, BinaryKitten.
See #53635.

File:

• trunk/src/wp-login.php (modified) (1 diff)

trunk/src/wp-login.php

@@ -1268 +1268 @@
             } elseif ( isset( $_GET['redirect_to'] ) && false !== strpos( $_GET['redirect_to'], 'wp-admin/authorize-application.php' ) ) {
                 $query_component = wp_parse_url( $_GET['redirect_to'], PHP_URL_QUERY );
-                parse_str( $query_component, $query );
+                $query           = array();
+                if ( $query_component ) {
+                    parse_str( $query_component, $query );
+                }
 
                 if ( ! empty( $query['app_name'] ) ) {