Changeset 51850

Timestamp:

09/22/2021 08:59:15 PM (4 years ago)

Author:

johnbillion

Message:

General: Fix code quality issues which were identified by static analysis.

This fixes minor issues that could cause PHP notices under the right conditions, and fixes some general incorrectness.

Props jrf, hellofromTonya for review

See #52217

Location:

trunk/src

Files:

• wp-admin/edit.php (modified) (1 diff)
• wp-admin/includes/class-wp-list-table.php (modified) (3 diffs)
• wp-includes/class-wp-http-curl.php (modified) (1 diff)
• wp-includes/class-wp-http-streams.php (modified) (1 diff)
• wp-includes/post.php (modified) (2 diffs)
• wp-includes/widgets.php (modified) (1 diff)
• wp-includes/widgets/class-wp-widget-tag-cloud.php (modified) (1 diff)
• wp-mail.php (modified) (1 diff)

trunk/src/wp-admin/edit.php

@@ -155 +155 @@
             $sendback = add_query_arg( 'untrashed', $untrashed, $sendback );
 
-            remove_filter( 'wp_untrash_post_status', 'wp_untrash_post_set_previous_status', 10, 3 );
+            remove_filter( 'wp_untrash_post_status', 'wp_untrash_post_set_previous_status', 10 );
 
             break;

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -208 +208 @@
      *
      * @param string $name Property to check if set.
-     * @return bool Whether the property is set.
+     * @return bool Whether the property is a back-compat property and it is set.
      */
     public function __isset( $name ) {
@@ -214 +214 @@
             return isset( $this->$name );
         }
+
+        return false;
     }
 
@@ -314 +316 @@
             return $this->_pagination_args[ $key ];
         }
+
+        return 0;
     }
 

trunk/src/wp-includes/class-wp-http-curl.php

@@ -308 +308 @@
 
         // Handle redirects.
-        $redirect_response = WP_HTTP::handle_redirects( $url, $parsed_args, $response );
+        $redirect_response = WP_Http::handle_redirects( $url, $parsed_args, $response );
         if ( false !== $redirect_response ) {
             return $redirect_response;

trunk/src/wp-includes/class-wp-http-streams.php

@@ -471 +471 @@
  * @deprecated 3.7.0 Please use WP_HTTP::request() directly
  */
-class WP_HTTP_Fsockopen extends WP_HTTP_Streams {
+class WP_HTTP_Fsockopen extends WP_Http_Streams {
     // For backward compatibility for users who are using the class directly.
 }

trunk/src/wp-includes/post.php

@@ -5507 +5507 @@
         return get_post( $foundid, $output );
     }
+
+    return null;
 }
 
@@ -5564 +5566 @@
         return get_post( $page, $output );
     }
+
+    return null;
 }
 

trunk/src/wp-includes/widgets.php

@@ -1740 +1740 @@
     $show_author  = isset( $widget_rss['show_author'] ) ? (int) $widget_rss['show_author'] : 0;
     $show_date    = isset( $widget_rss['show_date'] ) ? (int) $widget_rss['show_date'] : 0;
+    $error        = false;
+    $link         = '';
 
     if ( $check_feed ) {
-        $rss   = fetch_feed( $url );
-        $error = false;
-        $link  = '';
+        $rss = fetch_feed( $url );
+
         if ( is_wp_error( $rss ) ) {
             $error = $rss->get_error_message();

trunk/src/wp-includes/widgets/class-wp-widget-tag-cloud.php

@@ -53 +53 @@
             }
         }
+
+        $default_title = $title;
 
         $show_count = ! empty( $instance['count'] );

trunk/src/wp-mail.php

@@ -78 +78 @@
     $post_author               = 1;
     $author_found              = false;
+    $post_date                 = null;
+    $post_date_gmt             = null;
+
     foreach ( $message as $line ) {
         // Body signal.