Changeset 51850 for trunk/src/wp-includes/widgets.php

Timestamp:

09/22/2021 08:59:15 PM (2 years ago)

Author:

johnbillion

Message:

General: Fix code quality issues which were identified by static analysis.

This fixes minor issues that could cause PHP notices under the right conditions, and fixes some general incorrectness.

Props jrf, hellofromTonya for review

See #52217

File:

• trunk/src/wp-includes/widgets.php (modified) (1 diff)

trunk/src/wp-includes/widgets.php

@@ -1740 +1740 @@
     $show_author  = isset( $widget_rss['show_author'] ) ? (int) $widget_rss['show_author'] : 0;
     $show_date    = isset( $widget_rss['show_date'] ) ? (int) $widget_rss['show_date'] : 0;
+    $error        = false;
+    $link         = '';
 
     if ( $check_feed ) {
-        $rss   = fetch_feed( $url );
-        $error = false;
-        $link  = '';
+        $rss = fetch_feed( $url );
+
         if ( is_wp_error( $rss ) ) {
             $error = $rss->get_error_message();