Changeset 51857

Timestamp:

09/23/2021 09:29:07 PM (3 years ago)

Author:

hellofromTonya

Message:

Build/Test Tools: Upgrades Tests_Multisite_MS_Permalink_Collision fixture methods and strict assertion.

Improvements include:

• Upgrades the test fixture methods to the new snake_case methods.
• Reorders the fixture methods for consistency.
• Uses strict assertions of assertSame and assertNotSame.

Follow-up to [51855-51856].

Props hellofromTonya.
See #51147.

File:

• trunk/tests/phpunit/tests/multisite/msPermalinkCollision.php (modified) (3 diffs)

trunk/tests/phpunit/tests/multisite/msPermalinkCollision.php

@@ -44 +44 @@
         }
 
-        public function setUp() {
-            global $wpdb;
-            parent::setUp();
-            $this->suppress = $wpdb->suppress_errors();
-        }
-
-        public function tearDown() {
-            global $wpdb;
-            $wpdb->suppress_errors( $this->suppress );
-            parent::tearDown();
-        }
-
         /**
          * Delete blog and pages we created.
@@ -66 +54 @@
         }
 
+        public function set_up() {
+            global $wpdb;
+            parent::set_up();
+            $this->suppress = $wpdb->suppress_errors();
+        }
+
+        public function tear_down() {
+            global $wpdb;
+            $wpdb->suppress_errors( $this->suppress );
+            parent::tear_down();
+        }
+
         public function test_avoid_blog_page_permalink_collision_renames_post_name() {
-            $this->assertNotEquals( self::$post_and_blog_path, self::$root_page->post_name );
+            $this->assertNotSame( self::$post_and_blog_path, self::$root_page->post_name );
         }
 
@@ -76 +76 @@
          */
         public function test_avoid_blog_page_permalink_collision_doesnt_rename_child_pages() {
-            $this->assertEquals( self::$post_and_blog_path, self::$child_page->post_name );
+            $this->assertSame( self::$post_and_blog_path, self::$child_page->post_name );
         }
     }