Changeset 51859

Timestamp:

09/24/2021 12:29:46 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Further improve the tests for avoid_blog_page_permalink_collision():

• Rename the test filename and class to match the name of the function being tested.
• Remove unnecessary setUp() and tearDown() methods.
• Replace the only test group with post.

Follow-up to [51855-51857].

See #51147.

File:

• trunk/tests/phpunit/tests/multisite/avoidBlogPagePermalinkCollision.php (moved) (moved from trunk/tests/phpunit/tests/multisite/msPermalinkCollision.php ) (3 diffs)

trunk/tests/phpunit/tests/multisite/avoidBlogPagePermalinkCollision.php

@@ -7 +7 @@
          *
          * @group multisite
-         * @group only
+         * @group post
          */
-        class Tests_Multisite_MS_Permalink_Collision extends WP_UnitTestCase {
-                protected $suppress = false;
+        class Tests_Multisite_AvoidBlogPagePermalinkCollision extends WP_UnitTestCase {
                 protected static $site_id;
                 protected static $root_page;
@@ -54 +53 @@
                 }
 
-                public function set_up() {
-                        global $wpdb;
-                        parent::set_up();
-                        $this->suppress = $wpdb->suppress_errors();
-                }
-
-                public function tear_down() {
-                        global $wpdb;
-                        $wpdb->suppress_errors( $this->suppress );
-                        parent::tear_down();
-                }
-
                 public function test_avoid_blog_page_permalink_collision_renames_post_name() {
                         $this->assertNotSame( self::$post_and_blog_path, self::$root_page->post_name );
@@ -71 +58 @@
 
                 /**
-                 * Ensure `avoid_blog_page_permalink_collision()` doesn't rename child pages post_name.
+                 * Ensure `avoid_blog_page_permalink_collision()` doesn't rename child pages' post_name.
                  *
                  * @ticket 51147