Changeset 51882 for trunk

Timestamp:

10/02/2021 09:43:26 PM (3 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Sort widget types by their id.

Fixes #53303.
Props spacedmonkey.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-widget-types-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php

@@ -238 +238 @@
         }
 
+        ksort( $widgets );
+
         return $widgets;
     }

trunk/tests/phpunit/tests/rest-api/rest-widget-types-controller.php

@@ -127 +127 @@
 
     /**
+     * @ticket 53303
+     */
+    public function test_get_items_ordering() {
+        wp_set_current_user( self::$admin_id );
+        $request  = new WP_REST_Request( 'GET', '/wp/v2/widget-types' );
+        $response = rest_get_server()->dispatch( $request );
+        $data     = $response->get_data();
+        $this->assertGreaterThan( 1, count( $data ) );
+        $ids    = wp_list_pluck( $data, 'id' );
+        $sorted = $ids;
+        sort( $sorted );
+
+        $this->assertSame( $sorted, $ids );
+    }
+
+    /**
      * @ticket 53305
      */