Changeset 51892

Timestamp:

10/05/2021 11:09:21 PM (3 years ago)

Author:

hellofromTonya

Message:

Permalinks: Move the Nginx documentation link to help sidebar in wp-admin/options-permalink.php.

The "Documentation on Nginx configuration." link is out of place being below the "Save Changes" button on the Settings > Permalinks UI.

This commit relocates the link to join the other support related content links in the help tab's "For more information:" right sidebar area.

Follow-up to [34691], [45674].

Props audrasjb, hellofromTonya, johnjamesjacoby, mukesh27, peterwilsoncc, timlappe.
Fixes #39258.

File:

• trunk/src/wp-admin/options-permalink.php (modified) (2 diffs)

trunk/src/wp-admin/options-permalink.php

@@ -57 +57 @@
 );
 
-get_current_screen()->set_help_sidebar(
-    '<p><strong>' . __( 'For more information:' ) . '</strong></p>' .
-    '<p>' . __( '<a href="https://wordpress.org/support/article/settings-permalinks-screen/">Documentation on Permalinks Settings</a>' ) . '</p>' .
-    '<p>' . __( '<a href="https://wordpress.org/support/article/using-permalinks/">Documentation on Using Permalinks</a>' ) . '</p>' .
-    '<p>' . __( '<a href="https://wordpress.org/support/">Support</a>' ) . '</p>'
-);
+$help_sidebar_content = '<p><strong>' . __( 'For more information:' ) . '</strong></p>' .
+                        '<p>' . __( '<a href="https://wordpress.org/support/article/settings-permalinks-screen/">Documentation on Permalinks Settings</a>' ) . '</p>' .
+                        '<p>' . __( '<a href="https://wordpress.org/support/article/using-permalinks/">Documentation on Using Permalinks</a>' ) . '</p>';
+
+if ( $is_nginx ) {
+    $help_sidebar_content .= '<p>' . __( '<a href="https://wordpress.org/support/article/nginx/">Documentation on Nginx configuration</a>.' ) . '</p>';
+}
+
+$help_sidebar_content .= '<p>' . __( '<a href="https://wordpress.org/support/">Support</a>' ) . '</p>';
+
+get_current_screen()->set_help_sidebar( $help_sidebar_content );
+unset( $help_sidebar_content );
 
 $home_path           = get_home_path();
@@ -411 +417 @@
         <?php endif; ?>
     <?php endif; ?>
-<?php elseif ( $is_nginx ) : ?>
-    <p><?php _e( '<a href="https://wordpress.org/support/article/nginx/">Documentation on Nginx configuration</a>.' ); ?></p>
-    <?php
+        <?php
 else :
     if ( $permalink_structure && ! $using_index_permalinks && ! $writable && $htaccess_update_required ) :